Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

코스 목록 페이지 퍼블리싱 #64

Merged
merged 16 commits into from
Nov 23, 2022
Merged

코스 목록 페이지 퍼블리싱 #64

merged 16 commits into from
Nov 23, 2022

Conversation

claycat
Copy link
Collaborator

@claycat claycat commented Nov 22, 2022

Feature

코스 목록 페이지 퍼블리싱

  • 배경
    • 코스 목록 페이지를 퍼블리싱합니다
  • 목적
    • 코스 목록 페이지를 퍼블리싱합니다

과정

  • 오타 수정 : src/styles/font.ts Midium -> Medium
  • <Header/> 컴포넌트에서 뒤로가기 버튼에 cursor: pointer 추가
  • 필터 기능 구현 (API 호출 없음)
  • 무한 스크롤 기능 추가 (react-infinite-scroll-component 사용)
  • Modal 컴포넌트의 css를 opacity: 0.3 에서 (background-color: rgba(0, 0, 0, 0.3) 로 변경했습니다
    (아래 사진과 같이 children도 같이 투명해지는데 변경이 안되는 문제가 있었음)

image

결과 (스크린샷 등)

## 관련 issue 번호 (링크) - #55 ## 테스트 방법 - 필터 눌러보기 - 스크롤 내려보기

Commit

@claycat claycat added this to the 3주차 milestone Nov 22, 2022
@claycat
Copy link
Collaborator Author

claycat commented Nov 22, 2022

useCallback이나 useReducer를 사용하면 좋을것같은데 어디에서 써야할지 정확히 모르겠어요;;
가능하다면 나중에 리팩토링 하겠습니다

@June1010 June1010 self-requested a review November 23, 2022 02:13
Copy link
Member

@June1010 June1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pushedrumex pushedrumex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gchoi96 gchoi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@claycat claycat merged commit 9bb6709 into develop Nov 23, 2022
@gchoi96 gchoi96 deleted the feat/coursespage branch November 23, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants