Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/loginpage : 로그인페이지 퍼블리싱 및 버그픽스 #35

Merged
merged 2 commits into from
Nov 19, 2022

Conversation

claycat
Copy link
Collaborator

@claycat claycat commented Nov 19, 2022

Feature

로그인페이지 퍼블리싱

  • 배경
    • 로그인페이지 퍼블리싱
  • 목적
    • 로그인페이지 퍼블리싱

작업내용

  • 임시로 라우팅페이지를 만들었습니다( localhost:3000이 좀 허전해서요)
  • 화면을 좌우로 늘렸을 때 가운데 구분선이 한쪽으로 붙어서 개선했습니다
    image
  • div 구조상 cursor pointer가 전체에 걸려있어서 글자가 아닌 부분에도 클릭하면 반응했는데,
    글자에만 클릭되도록 수정했습니다
  • InputValidator 버그를 수정했습니다 (Input validator 버그 #33)
  • 구분선이 scale 가능하도록 first-child 에서 :not(:last-child)로 변경했습니다
  • 비밀번호 확인 에러문구를 수정했습니다 비밀번호를 한번 더 입력하세요 -> 비밀번호가 일치하지 않습니다

결과 (스크린샷 등)

image

관련 issue 번호 (링크)

테스트 방법

Commit

@claycat claycat added this to the 2주차 milestone Nov 19, 2022
Copy link
Member

@gchoi96 gchoi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

Comment on lines 28 to 31
.post("http://localhost:4000/auth/login", {
userId: userId,
password: password,
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shorthand 형식으로 작성하셔도 괜찮을 것 같습니다

  axios
            .post("http://localhost:4000/auth/login", {
                userId,
                password,
            })

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저게 되는군요 ㄷㄷ

if (!/^[a-zA-Z0-9]*$/g.test(id)) return "영문 대소문자, 숫자만 입력이 가능합니다";
return "ID는 6자 이상 20자 이하여야 합니다";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다🙇‍♂️

Copy link
Member

@pushedrumex pushedrumex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pushedrumex pushedrumex merged commit 74edf2b into develop Nov 19, 2022
@gchoi96 gchoi96 deleted the feat/loginpage branch November 23, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants