Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ID 중복 체크 / 회원가입 입력 항목 추가 #192

Merged
merged 2 commits into from
Dec 6, 2022
Merged

feat: ID 중복 체크 / 회원가입 입력 항목 추가 #192

merged 2 commits into from
Dec 6, 2022

Conversation

gchoi96
Copy link
Member

@gchoi96 gchoi96 commented Dec 6, 2022

Feature

  • 배경
    • 메일 알림 기능을 추가하면서 유저의 메일 주소와 수신 동의 여부를 수집할 필요가 생김
  • 목적
    • id 중복 체크 API 연동
    • 메일 주소와 수신 동의 여부를 수집할 필요가 생김

과정

  • id 중복 체크 API 연동
  • 회원 가입 폼에서 메일 주소와 수신 동의 여부 입력받도록 수정

결과 (스크린샷 등)

image

관련 issue 번호 (링크)

테스트 방법

Commit

@gchoi96 gchoi96 self-assigned this Dec 6, 2022
pushedrumex
pushedrumex approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@pushedrumex pushedrumex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gchoi96 gchoi96 merged commit 57d05ab into develop Dec 6, 2022
@gchoi96 gchoi96 mentioned this pull request Dec 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pushedrumex pushedrumex pushedrumex approved these changes

@claycat claycat claycat approved these changes

@June1010 June1010 Awaiting requested review from June1010

Assignees

@gchoi96 gchoi96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gchoi96 @claycat @pushedrumex