Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/card image to map #174

Merged
merged 3 commits into from
Dec 1, 2022
Merged

Conversation

gchoi96
Copy link
Member

@gchoi96 gchoi96 commented Dec 1, 2022

Feature

  • 배경
    • 카카오 정책 문제로 지도를 캡처하지 못하는 문제가 있음
    • 카드 컴포넌트에서 지도 이미지를 사용할 수 없게됨
    • 이미지 대신 지도를 사용하기로 함
  • 목적
    • 기존 img 태그를 카카오 지도로 변경

과정

  • 카드 컴포넌트에서 사용할 지도를 반환해주는 useCardHook() 작성
  • 카드 컴포넌트에 적용

결과 (스크린샷 등)

image

관련 issue 번호 (링크)

테스트 방법

Commit

@gchoi96 gchoi96 self-assigned this Dec 1, 2022
Copy link
Member

@pushedrumex pushedrumex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pushedrumex pushedrumex merged commit 66b08e0 into develop Dec 1, 2022
@gchoi96 gchoi96 mentioned this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants