Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 확인 모달창 -> 모집 참여, 모집 생성, 코스 생성 #166

Merged
merged 2 commits into from
Dec 1, 2022
Merged

feat: 확인 모달창 -> 모집 참여, 모집 생성, 코스 생성 #166

merged 2 commits into from
Dec 1, 2022

Conversation

pushedrumex
Copy link
Member

Feature

  • 배경
    모집 게시글을 올리기 전, 모집에 참여하기 전, 코스를 생성하기 전 확인 모달창으로 재확인한다.
  • 목적
    모집 게시글을 올리기 전, 모집에 참여하기 전, 코스를 생성하기 전 확인 모달창으로 재확인한다.

과정

확인창 공통 컴포넌트를 활용한다.

결과 (스크린샷 등)

스크린샷 2022-12-01 오후 1 56 14

스크린샷 2022-12-01 오후 2 02 04

스크린샷 2022-12-01 오후 2 29 00

관련 issue 번호 (링크)

#165

테스트 방법

Commit

@pushedrumex pushedrumex self-assigned this Dec 1, 2022
@June1010 June1010 self-requested a review December 1, 2022 07:46
gchoi96
gchoi96 approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@gchoi96 gchoi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pushedrumex pushedrumex merged commit e56ddaf into develop Dec 1, 2022
@pushedrumex pushedrumex deleted the feat/confirm-modal branch December 1, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchoi96 gchoi96 gchoi96 approved these changes

@June1010 June1010 June1010 approved these changes

Assignees

@pushedrumex pushedrumex

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pushedrumex @June1010 @gchoi96