Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fe 구조/hooks 개선 #132

Merged
merged 4 commits into from
Nov 28, 2022
Merged

refactor: fe 구조/hooks 개선 #132

merged 4 commits into from
Nov 28, 2022

Conversation

gchoi96
Copy link
Member

@gchoi96 gchoi96 commented Nov 28, 2022

Feature

배경

  • 현재 pages 디럭터리 아래에 바로 Page.tsx Page.styles.ts 파일이 위치하고 있어 관리가 어려움
  • custom hooks의 인자/타입이 명확하지 않아 한 번에 파악하기 어려움
    useInput(validator, false)
  • 각 페이지/컴포넌트가 너무 많은 기능을 수행하고 있어 관리가 어려움

목적

  • 페이지별 디렉터리를 따로 만들어 관리
  • hooks 로직 개선

과정

  • 페이지별 하위 디렉터리 생성
  • hooks 로직 개선

결과 (스크린샷 등)

관련 issue 번호 (링크)

테스트 방법

Commit

@gchoi96 gchoi96 self-assigned this Nov 28, 2022
pushedrumex
pushedrumex approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@pushedrumex pushedrumex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gchoi96
refactor: #131 누락된 story 파일 작성
e08a151 
Text, Template -> _ComponentName
June1010
June1010 approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@June1010 June1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gchoi96 gchoi96 merged commit 6e18d08 into develop Nov 28, 2022
pushedrumex
pushedrumex approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@pushedrumex pushedrumex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gchoi96 gchoi96 deleted the refactor/fe-refactoring branch December 1, 2022 11:43
@gchoi96 gchoi96 restored the refactor/fe-refactoring branch December 7, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pushedrumex pushedrumex pushedrumex approved these changes

@June1010 June1010 June1010 approved these changes

@claycat claycat Awaiting requested review from claycat

Assignees

@gchoi96 gchoi96

Labels
frontend refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gchoi96 @June1010 @pushedrumex