Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 주소 검색 컴포넌트 구현 #113

Merged
merged 5 commits into from
Nov 28, 2022
Merged

Conversation

gchoi96
Copy link
Member

@gchoi96 gchoi96 commented Nov 26, 2022

Feature

  • 배경
    • SignUp 페이지에 주소 검색 기능이 바로 붙어있어 관리가 어려움
    • input이 변경될 때마다 주소 검색 요청을 보내고 있음 (필요 이상으로 많은 요청이 전송됨)
  • 목적
    • 주소 검색 기능을 별도의 컴포넌트로 분리
      • 주소 검색 컴포넌트 story 작성
    • 주소 검색 컴포넌트에 디바운싱 적용

과정

  • 주소 검색 컴포넌트 분리
  • 주소 검색 컴포넌트 디바운싱

결과 (스크린샷 등)

화면 기록 2022-11-26 오후 7 50 54

관련 issue 번호 (링크)

테스트 방법

스토리북 + 리액트 앱

Commit

@gchoi96 gchoi96 self-assigned this Nov 26, 2022
Copy link
Collaborator

@claycat claycat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pushedrumex pushedrumex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pushedrumex pushedrumex merged commit 03747f7 into develop Nov 28, 2022
@gchoi96 gchoi96 deleted the feat/address-search branch December 1, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants