Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: time->hour로 파라미터 변경 작업 및 응답에서 course.userId가 누락되어 있던 문제 수정 #111

Merged
merged 1 commit into from
Nov 26, 2022

Conversation

June1010
Copy link
Member

Feature

  • 배경
    • time 대신 hour로 쿼리스트링을 변경하기로 결정 (의미를 좀 더 명확하게 전달 위함)
    • 기존 응답에서 course 부분에서 userId가 누락되어 있음
  • 목적
    • time 대신 hour로 변경 (예시: GET /recruit?query=randomTitle&hour=3)
    • userId 누락 문제 수정

과정

  • 해당 레이어 수정
  • 쿼리문 일부 수정

결과 (스크린샷 등)

image

관련 issue 번호 (링크)

#110

테스트 방법

Postman

Comment

Recruit page에서도 쿼리파라미터로 time 대신 hour로 변경해서 보내게끔 수정 필요할 것 같습니다.

@June1010 June1010 requested review from pushedrumex, claycat and gchoi96 and removed request for pushedrumex November 26, 2022 09:52
@June1010 June1010 self-assigned this Nov 26, 2022
Copy link
Member

@gchoi96 gchoi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@claycat claycat merged commit 6be0ed0 into develop Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants