ADD : bm25 #37
Merged
ADD : bm25 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goattier
commented
Oct 19, 2021
code/retrieval_bm25.py
Outdated
Comment on lines
84
to
88
| self.bm25 = BM25Okapi(self.contexts, tokenizer=self.tokenize_fn, k1=1.2, b=0.75) | ||
| tokenized_contexts = [self.tokenize_fn(c) for c in self.contexts] |
There was a problem hiding this comment.
multiprocess pool 로 tokenizing 시 발생되는 issue로 인해 list comprehension으로 변경
[22secs -> 84secs]
-> bin파일 load로 개선
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retrieval_bm25.py 추가.
inference.py -> run_sparse_retireval에서 SparseRetrieval 대신 사용하시면 됩니다.