[FE] Issue sidebar component #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 9, 2020 16:31
아이콘을 사용하기 위해서 styled-icons 종속성을 추가하였다.
issue Sidebar 메뉴에 들어가는 Item 컴포넌트를 개발하였다. 재사용을 고려하여 props와 children을 사용하여 만들었다.
이슈 상세화면에 있는 사이드바 컴포넌트를 구현하였다. progress Bar은 추후 팀원이 컴포넌트를 만들어 주면 그때 컴포넌트를 바꿔 넣을 계획이다.
moaikang
added
Feature 🎨
maong0927
reviewed
Nov 9, 2020
| display: flex; | ||
| align-items: center; | ||
|
|
||
| margin-bottom: 7px; |
There was a problem hiding this comment.
pixel 로 margin 을 설정하면 화면 크기에 따라 모양이 바뀌지 않을까요?
| `; | ||
|
|
||
| export const LabelWrapper = styled.div<{color: string}>` | ||
| padding: 6px 5px; |
namda-on
approved these changes
Nov 9, 2020
Comment on lines
+9
to
+24
| export default function IssueSideBarItem({menuName, children} : IssueSideBarItemProps) { | ||
| const [isHover, setIsHover] = useState<boolean>(false); | ||
|
|
||
| return ( | ||
| <S.ItemWrapper> | ||
| <S.ItemHead> | ||
| <S.MenuName onMouseEnter={() => setIsHover(true)} onMouseLeave={() => setIsHover(false)} isHover={isHover}>{menuName}</S.MenuName> | ||
| <S.SettingIcon onMouseEnter={() => setIsHover(true)} onMouseLeave={() => setIsHover(false)} isHover={isHover}/> | ||
| </S.ItemHead> | ||
|
|
||
| <S.ItemBody> | ||
| {children} | ||
| </S.ItemBody> | ||
| </S.ItemWrapper> | ||
| ) | ||
| } |
There was a problem hiding this comment.
childeren 을 받아서 재활용 할 수 있어서 좋은 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Close #222
변경사항
새로운 기능
작업 유형
체크리스트