Fix reselect poi #127
Open
Fix reselect poi #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(map): Test fix (when scrolling down the bottom sheet, it was impossible to re select the boulder selected previously)
wang-li
reviewed
May 27, 2024
|
@joxad Can you add a short description of the problem in the PR description, as well as a two screen recordings demonstrating the issue and the fixed behavior please? 🙏 |
|
Version Prod with the bug https://photos.app.goo.gl/tcxDyKGD5XB64yY77 |
|
Version dev with the fix |
|
Bug is : When you select a poi, swipe down the bottom sheet, and then reselect the poi, the bottom sheet doesn't expand properly. |
wang-li
reviewed
May 29, 2024
| @@ -118,6 +118,7 @@ class MapFragment : Fragment(), BoolderMapListener { | |||
| when (newState) { | |||
| STATE_EXPANDED -> mapViewModel.onProblemTopoVisibilityChanged(isVisible = true) | |||
| STATE_HIDDEN -> { | |||
| mapViewModel.onTopoUnselected() | |||
There was a problem hiding this comment.
Looks like a call to mapView.unselectProblem() is missing, as the boulder problem stays selected when dismissing the topo bottom sheet from a back press or dragging it down (the unselectProblem() function's scope can be changed from private to public)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.