-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix multiple issues from user exports config changes #3238
Conversation
- improve nginx config - fix DATA_UPLOAD_MAX_MEMORY_SIZE default not being an int - translate fallback value in id_to_username template tag - make location of setting to turn on user exports easier to locate for admins fixes bookwyrm-social#3227 fixes bookwyrm-social#3231 fixes bookwyrm-social#3232 fixes bookwyrm-social#3236
I'm not at all confident about the nginx changes (at the very least there's surely a more succinct way to do this) so advice on that would be welcome. @mouse-reeve I'm also not entirely confident I'm using |
I found some other translation issues, so I went through and fixed the lot. To your specific question, you can set the url variable using <br/>
{% url 'settings-imports' as url %}
{% blocktrans trimmed %}
User exports settings can be changed from <a href="{{ url }}">the Imports page</a> in the Admin dashboard.
{% endblocktrans %} |
Since arithmetic is not allowed in .env files, a change in unit for the variable seems most usable.
Support DATA_UPLOAD_MAX_MEMORY_MiB, only, in .env
@bookwyrm-social/code-review this is ready for final review. There is still an issue with the reverse-proxy nginx config however I'm going to log that as a separate issue rather than bog down this PR, as I'm probably not the best person to fix it. Thanks @dato and @mouse-reeve for your help! |
fixes #3227
fixes #3231
fixes #3232
fixes #3236