Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Ukranian locale and updates locales #3154

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Adds Ukranian locale and updates locales #3154

merged 5 commits into from
Jan 2, 2024

Conversation

mouse-reeve
Copy link
Member

No description provided.

@0x29a
Copy link
Contributor

0x29a commented Dec 17, 2023

Oof, thank you for adding the locale, @mouse-reeve. May I ask you to wait a few days before merging this, until I finish translating at least django.po? (Nit: the title is missing one letter: Ukranian -> Ukrainian). I'll hurry up. 🙂

bookwyrm/settings.py Outdated Show resolved Hide resolved
bw-dev Outdated Show resolved Hide resolved
bookwyrm/migrations/0189_alter_user_preferred_language.py Outdated Show resolved Hide resolved
@mouse-reeve
Copy link
Member Author

Oof, thank you for adding the locale, @mouse-reeve. May I ask you to wait a few days before merging this, until I finish translating at least django.po? (Nit: the title is missing one letter: Ukranian -> Ukrainian). I'll hurry up. 🙂

Sure thing! Thank you so much for updating the translations

@mouse-reeve
Copy link
Member Author

I was able to replicate these tests failing; when I changed my system clock to a different day, the tests pass.

@0x29a
Copy link
Contributor

0x29a commented Dec 31, 2023

@mouse-reeve, I'll try to look into this today. There are also still 3 pages left to translate, I apologize for the delay.

@mouse-reeve mouse-reeve merged commit 5647477 into main Jan 2, 2024
10 checks passed
@mouse-reeve mouse-reeve deleted the ukrainian branch January 2, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants