-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move .babelrc to src/ #1470
Move .babelrc to src/ #1470
Conversation
Is there any way we could get this merged? |
I am not an expert with Babel. |
no idea @dj-hedgehog |
No, babel files simply apply to all files in the directory they are in and sub-directories under them. So moving .babelrc to src/ only changes things so that the .babelrc doesn't apply to anything outside of src/. And from what I can see your tests and the root bookshelf.js do not use transpiled syntax. |
we are in process to discuss about the complete removal of babel from the codebase , in #1606 , please come there to discuss about any cons in the process if we will choose to maintain babel we will merge this PR |
What about merging and removing babel if the issue resolves to that later? |
Sounds good to me. What do you think @mrhwick ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Babel will look for a .babelrc in the current directory of the file being transpiled. If one does not exist, it will travel up the directory tree until it finds either a .babelrc, or a package.json with a "babel": {} hash within.
Fixes #1460