This repository has been archived by the owner on May 3, 2022. It is now read-only.
Introduce fleet summary report in Capacity Target #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
February 20, 2019 09:38
This is still incomplete: container entries should be aggregated when processing container states.
…with different pod conditions
* Remove unused field * Fix sort predicate implementation
* Remove unused field
osdrv
reviewed
Mar 1, 2019
| package builder | ||
|
|
||
| import ( | ||
| "github.com/pmezard/go-difflib/difflib" |
There was a problem hiding this comment.
A minor remark: this package is no longer maintained, we might consider forking it or using an alternative.
There was a problem hiding this comment.
We already vendor it in the project. If required, we could fork it into bookingcom organization and change the import path.
Do you think this is relevant for this PR?
osdrv
previously approved these changes
Mar 1, 2019
function to `AddOrIncrementContainerState` since it matches what the function does more closely. Also changed `AddState` to `AddOrIncrementState` and removed the argument there, too. I'm leaving the `initialCount` argument of `NewPodBuilder` untouched because that one is actually set at object instantiation time, and it's always taken into account, unlike the two functions I mentioned above.
osdrv
approved these changes
Mar 11, 2019
osdrv
approved these changes
Mar 18, 2019
parhamdoustdar
approved these changes
Mar 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the fleet summary report in Capacity Target objects. This report is intended to be used to produce more meaningful conditions in Release objects, to help Shipper users to better understand their applications' status across Shipper managed clusters.
The approach chosen to implement this feature was to create a report builder. This report builder accumulates relevant Pod data while iterating the list of Pods in a single cluster.
The decision of introducing a builder happened in the middle of the implementation, after introducing builders for testing purposes, which shed some light on the complexity of the original implementation, so I advise not review this PR per commit.
Closes #21