This repository has been archived by the owner on May 3, 2022. It is now read-only.
Measure time from Application creation/modification to Chart Installation #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lation This is the first iteration of gathering information from the moment an application is modified to the moment that the chart is installed. We're measuring the time it takes Shipper to render the chart, install it, and report that it has been installed.
Metrics controller stores the last modified time of each application as it is created or updated. It's possible that for some reasons (e.g. releases not getting rolled out for a long time, the informers missing events, and other cases that I don't currently know of) our cache would grow to be too big. This commit adds code to prevent that from happening, by periodically cleaning up all the entries that have been added more than 1 hour ago. This period is currently defined as a constant. We can later get that as a command-line parameter if it turns out that we need to modify it in the deployment.
CRUNTIME-438
hihilla
approved these changes
Jan 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first iteration of gathering information from the moment
an application is modified to the moment that the chart is
installed. We're measuring the time it takes Shipper to render the
chart, install it, and report that it has been installed