Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

shipperctl: split "shipperctl admin clusters apply" #292

Merged
merged 2 commits into from
Mar 12, 2020
Merged

shipperctl: split "shipperctl admin clusters apply" #292

merged 2 commits into from
Mar 12, 2020

Conversation

juliogreff
Copy link
Contributor

First of all, this does away with the "admin" namespace. Commands were
getting too long for our taste.

Second, shipperctl admin clusters apply is now split into two,
supposed to be called in order, like so:

shipperctl clusters setup management
shipperctl clusters join -f clusters.yaml

The first only installs Shipper in the management cluster, and the
second joins application clusters to the management one. This allows us
to roll out updates to shipper without necessarily having to specify
application clusters to be joined.

@juliogreff
crd: remove legacy YAML definition of CRDs
5ca11b4 
These already exist as go files in `pkg/crd`, and keeping both of those
in sync was annoying without a very good reason, besides being able to
only install them without running shipperctl. We're going to split
shipperctl into more commands in follow up commits, so this is no
longer necessary.
@juliogreff
shipperctl: split "shipperctl admin clusters apply"
e5d0426 
First of all, this does away with the "admin" namespace. Commands were
getting too long for our taste.

Second, `shipperctl admin clusters apply` is now split into two,
supposed to be called in order, like so:

```
shipperctl clusters setup management
shipperctl clusters join -f clusters.yaml
```

The first only installs Shipper in the management cluster, and the
second joins application clusters to the management one. This allows us
to roll out updates to shipper without necessarily having to specify
application clusters to be joined.
@juliogreff juliogreff added the enhancement New feature or request label Mar 5, 2020
@juliogreff juliogreff added this to the release-0.9 milestone Mar 5, 2020
@juliogreff juliogreff self-assigned this Mar 5, 2020
@parhamdoustdar parhamdoustdar merged commit 3b047ae into master Mar 12, 2020
@parhamdoustdar parhamdoustdar deleted the jgreff/shipperctl-split branch March 12, 2020 15:07
osdrv pushed a commit that referenced this pull request Mar 23, 2020
Shipperctl installs management and application CRDs independently
428a9e6 
Up until now, shipper has been installing CRD objects to management
clusters only and this was a part of `shipperctl clusters setup
management` command. As we're splitting shipper in management and
application components, these components need their own CRDs to
operate on the relevant cluster.

Therefore, an updated list of CRD groups:
* Management
  - Application
  - Release
  - Cluster
  - RolloutBlock
* Application
  - InstallationTarget
  - CapacityTarget
  - TrafficTarget

Folow-up to: #292

Signed-off-by: Oleg Sidorov <[email protected]>
@osdrv osdrv mentioned this pull request Mar 23, 2020
Closed
osdrv pushed a commit that referenced this pull request Apr 6, 2020
Shipperctl installs management and application CRDs independently
7e91442 
Up until now, shipper has been installing CRD objects to management
clusters only and this was a part of `shipperctl clusters setup
management` command. As we're splitting shipper in management and
application components, these components need their own CRDs to
operate on the relevant cluster.

Therefore, an updated list of CRD groups:
* Management
  - Application
  - Release
  - Cluster
  - RolloutBlock
* Application
  - InstallationTarget
  - CapacityTarget
  - TrafficTarget

Folow-up to: #292

Signed-off-by: Oleg Sidorov <[email protected]>
osdrv pushed a commit that referenced this pull request Apr 6, 2020
Shipperctl installs management and application CRDs independently
fc6e8b3 
Up until now, shipper has been installing CRD objects to management
clusters only and this was a part of `shipperctl clusters setup
management` command. As we're splitting shipper in management and
application components, these components need their own CRDs to
operate on the relevant cluster.

Therefore, an updated list of CRD groups:
* Management
  - Application
  - Release
  - Cluster
  - RolloutBlock
* Application
  - InstallationTarget
  - CapacityTarget
  - TrafficTarget

Folow-up to: #292

Signed-off-by: Oleg Sidorov <[email protected]>
osdrv pushed a commit that referenced this pull request Apr 6, 2020
Shipperctl installs management and application CRDs independently
5f42e5f 
Up until now, shipper has been installing CRD objects to management
clusters only and this was a part of `shipperctl clusters setup
management` command. As we're splitting shipper in management and
application components, these components need their own CRDs to
operate on the relevant cluster.

Therefore, an updated list of CRD groups:
* Management
  - Application
  - Release
  - Cluster
  - RolloutBlock
* Application
  - InstallationTarget
  - CapacityTarget
  - TrafficTarget

Folow-up to: #292

Signed-off-by: Oleg Sidorov <[email protected]>
osdrv pushed a commit that referenced this pull request Apr 6, 2020
Shipperctl installs management and application CRDs independently
4b2060d 
Up until now, shipper has been installing CRD objects to management
clusters only and this was a part of `shipperctl clusters setup
management` command. As we're splitting shipper in management and
application components, these components need their own CRDs to
operate on the relevant cluster.

Therefore, an updated list of CRD groups:
* Management
  - Application
  - Release
  - Cluster
  - RolloutBlock
* Application
  - InstallationTarget
  - CapacityTarget
  - TrafficTarget

Folow-up to: #292

Signed-off-by: Oleg Sidorov <[email protected]>
osdrv pushed a commit that referenced this pull request Apr 6, 2020
Shipperctl installs management and application CRDs independently
c3f0b61 
Up until now, shipper has been installing CRD objects to management
clusters only and this was a part of `shipperctl clusters setup
management` command. As we're splitting shipper in management and
application components, these components need their own CRDs to
operate on the relevant cluster.

Therefore, an updated list of CRD groups:
* Management
  - Application
  - Release
  - Cluster
  - RolloutBlock
* Application
  - InstallationTarget
  - CapacityTarget
  - TrafficTarget

Folow-up to: #292

Signed-off-by: Oleg Sidorov <[email protected]>
osdrv pushed a commit that referenced this pull request Apr 6, 2020
Shipperctl installs management and application CRDs independently
2993a74 
Up until now, shipper has been installing CRD objects to management
clusters only and this was a part of `shipperctl clusters setup
management` command. As we're splitting shipper in management and
application components, these components need their own CRDs to
operate on the relevant cluster.

Therefore, an updated list of CRD groups:
* Management
  - Application
  - Release
  - Cluster
  - RolloutBlock
* Application
  - InstallationTarget
  - CapacityTarget
  - TrafficTarget

Folow-up to: #292

Signed-off-by: Oleg Sidorov <[email protected]>
osdrv pushed a commit that referenced this pull request Apr 6, 2020
Shipperctl installs management and application CRDs independently
1c41ce7 
Up until now, shipper has been installing CRD objects to management
clusters only and this was a part of `shipperctl clusters setup
management` command. As we're splitting shipper in management and
application components, these components need their own CRDs to
operate on the relevant cluster.

Therefore, an updated list of CRD groups:
* Management
  - Application
  - Release
  - Cluster
  - RolloutBlock
* Application
  - InstallationTarget
  - CapacityTarget
  - TrafficTarget

Folow-up to: #292

Signed-off-by: Oleg Sidorov <[email protected]>
osdrv pushed a commit that referenced this pull request Apr 6, 2020
Shipperctl installs management and application CRDs independently
4714651 
Up until now, shipper has been installing CRD objects to management
clusters only and this was a part of `shipperctl clusters setup
management` command. As we're splitting shipper in management and
application components, these components need their own CRDs to
operate on the relevant cluster.

Therefore, an updated list of CRD groups:
* Management
  - Application
  - Release
  - Cluster
  - RolloutBlock
* Application
  - InstallationTarget
  - CapacityTarget
  - TrafficTarget

Folow-up to: #292

Signed-off-by: Oleg Sidorov <[email protected]>
osdrv pushed a commit that referenced this pull request Apr 6, 2020
Shipperctl installs management and application CRDs independently
066c734 
Up until now, shipper has been installing CRD objects to management
clusters only and this was a part of `shipperctl clusters setup
management` command. As we're splitting shipper in management and
application components, these components need their own CRDs to
operate on the relevant cluster.

Therefore, an updated list of CRD groups:
* Management
  - Application
  - Release
  - Cluster
  - RolloutBlock
* Application
  - InstallationTarget
  - CapacityTarget
  - TrafficTarget

Folow-up to: #292

Signed-off-by: Oleg Sidorov <[email protected]>
osdrv pushed a commit that referenced this pull request Apr 6, 2020
Shipperctl installs management and application CRDs independently
f0bcf36 
Up until now, shipper has been installing CRD objects to management
clusters only and this was a part of `shipperctl clusters setup
management` command. As we're splitting shipper in management and
application components, these components need their own CRDs to
operate on the relevant cluster.

Therefore, an updated list of CRD groups:
* Management
  - Application
  - Release
  - Cluster
  - RolloutBlock
* Application
  - InstallationTarget
  - CapacityTarget
  - TrafficTarget

Folow-up to: #292

Signed-off-by: Oleg Sidorov <[email protected]>
@hihilla hihilla mentioned this pull request Oct 8, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parhamdoustdar parhamdoustdar parhamdoustdar approved these changes

@osdrv osdrv osdrv approved these changes

Assignees

@juliogreff juliogreff

Labels
enhancement New feature or request
Projects
None yet
Milestone
release-0.9
Development

Successfully merging this pull request may close these issues.
3 participants
@juliogreff @osdrv @parhamdoustdar