Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue[19][20][25] solved. #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

d4r3topk
Copy link

This commit is for the theme issues and informing user about "no username","failed to fetch bookmarks", and when "updating bookmarks".(basically when cannot talk to server) . Takes care of Issues 19,20,25. Some different import statements due to workspace imports.

@d4r3topk
Copy link
Author

Also, modified README.org for developers to get around the extra libraries to import.

@craigmaloney
Copy link

@DerekV Would you give this a peek and see if it works?

@DerekV
Copy link
Contributor

DerekV commented Feb 3, 2015

Yep, will look later.
On Feb 3, 2015 11:56 AM, "Craig Maloney" [email protected] wrote:

@DerekV https://github.com/DerekV Would you give this a peek and see if
it works?


Reply to this email directly or view it on GitHub
#33 (comment)
.

@d4r3topk
Copy link
Author

d4r3topk commented Feb 7, 2015

@DerekV Did you have time to get a look at the code? I can start working on other issues, only if this one is okay.

@@ -46,6 +48,8 @@ private void dealWithIntents() {
populateFields(bmark);
} catch (JsonSyntaxException e) {
Log.e(TAG, "Error getting bookmark detail", e);
Toast.makeText(getActivity(),"Some error occured while fetching bookmark details" ,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a string resource instead of hard-coding a string

@DerekV
Copy link
Contributor

DerekV commented Feb 7, 2015

Thanks for working on this @d4r3topk
Will accept if style issues addressed.
I'm wondering if it would be nice to have a style guide for the code base

@d4r3topk
Copy link
Author

d4r3topk commented Feb 8, 2015

Thanks a lot @DerekV .I will address the style issues and update it. Yes, A style guide will save a lot of time for the other contributors. Also, Is committing on my branch(like this one) okay? And yes, I've checked the code on my android device, works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants