Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow automatically resolving response identities #9

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

glopesdev
Copy link
Member

This PR extends the SendResponse operator to automatically resolve response identities when the nested workflow output is a sequence of raw response frames. This extension also provides new overloads to allow more easily building response handlers which are compatible across both Response and Router sockets.

The implementation scans backwards from the request message looking for an empty delimiter frame. If it finds one, it assumes the preceding frames represent the identity of the request, and pushes them to the top of the response message. For simple Response sockets the request does not include any identity frames, and the response frames are routed directly back to the socket.

@glopesdev glopesdev added the feature New planned feature label Jan 3, 2023
@glopesdev glopesdev added this to the 0.1.0 milestone Jan 3, 2023
@glopesdev glopesdev requested a review from RoboDoig January 3, 2023 12:55
@glopesdev glopesdev merged commit e501929 into bonsai-rx:main Jan 3, 2023
@glopesdev glopesdev deleted the send-response branch January 3, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New planned feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant