Manage connection string using type converter #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the management of connection strings in the editor using a type converter instead of a custom type. All functionality should be preserved, except that all connection string property types are now
string
.This has the advantage of making operator properties more compatible when computing connection strings dynamically (e.g. loading from a file, etc).
The sub-properties
Host
andPort
were also fused into a more generalAddress
property, since there is a wider family of weirdly formatted connection strings which are possible in ZMQ that do not conform to the basic patternhostname:port
(see example section in zmq_pgm docs).