Check if GraphPane is null before attempting to modify CurveList #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
reviewed
Apr 19, 2024
|
@ncguilbeault ah, sorry! I think my edits didn't work well because I didn't correct the rest of the file which still has the extra indentation. The best way might be to just undo the two commits in the local branch, then you can just implement the check yourself and force push, that should solve everything. |
|
Okay, should be updated now |
glopesdev
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a change to the
BoundedGraphPanelclass, specifically theOnInvalidatedmethod, to check if theGraphPaneis null before attempting to interact with theGraphPane. On Linux/Mono, theOnInvalidatedmethod is being called before theGraphPaneis initialised, leading to an error when attempting to callGraphPane.CurveList. This seems to be a Linux specific issue, since the original code works fine on Windows. I've tested on Windows as well with the new modification and it seems to work okay.