Make package comparison in CI optional for the sake of forks #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PathogenDavid
changed the title
Forks won't always have the `latest` tag (and even if they do it might be very stale), so don't bother with package comparison unless the fork explicitly enables it
PathogenDavid
force-pushed
the
optional-package-comparison
branch
from
f9428fa to
8755afd
Compare
glopesdev
reviewed
Jul 5, 2024
glopesdev
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change to release automation I realized should be done after I saw your fork as failing CI.
Forks won't always have the
latesttag (and even if they do it might be stale), so don't bother with package comparison unless the fork explicitly enables it.⚠ Before merging you need to add an Actions variable
ENABLE_PACKAGE_COMPARISON=trueto this repo.(Forks can also choose to define that variable to assert that their
latesttag is valid and that they want the comparisons done.)Relates to #1873