Enable support for compressed XRefMap from documentation server #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Never forget what they took from us: dotnet/runtime@5fd3a23 dotnet/runtime#20829 |
glopesdev
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With today's Bonsai documentation, the GZip-compressed XRefMap is only 200 KB. That's down from 2.74 MB uncompressed 🎉
The TODO is so we hopefully remember to switch to
DecompressionMethods.Allwhen we upgrade to modern .NET so that we can take advantage of Brotli and any other future compression methods supported in the future.(Gonçalo and I considered manually using
~DecompressionMethods.Nonesince it works downlevel, but decided this might be confusing.)