Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent infinite recursion when visualizer mappings of the same node are combined together #1787

Merged
merged 1 commit into from
May 20, 2024
Merged

Prevent infinite recursion when visualizer mappings of the same node are combined together #1787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Bonsai.Editor/Layout/LayoutHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,10 @@ static IReadOnlyList<VisualizerFactory> GetMashupArguments(InspectBuilder builde
if (visualizerMappings.Count == 0) return Array.Empty<VisualizerFactory>();
return visualizerMappings.Select(mapping =>
{
// stack overflow happens if a visualizer ends up being mapped to itself
if (mapping.Source == builder)
throw new WorkflowBuildException("Combining together visualizer mappings from the same node is not currently supported.", builder);

var nestedSources = GetMashupArguments(mapping.Source, typeVisualizerMap);
var visualizerType = mapping.VisualizerType ?? typeVisualizerMap.GetTypeVisualizers(mapping.Source).FirstOrDefault();
return new VisualizerFactory(mapping.Source, visualizerType, nestedSources);
Expand Down
Loading