Fix GateInterval not working after the first tick #1767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by a change from the
Observable.Window(Func<IObservable<>> windowClosingSelector)
overload to theObservable.Window(IObservable<> windowBoundaries)
overload done in 606d6fe for #1315These two overloads don't actually act quite the same way:
The observable returned by
Observable.Timer
implicitly resets when it is re-subscribed, meaning it works fine with the former but only trigger once with the latter. (Essentially there was one window of the interval length followed by another which never closed.)Observable.Interval
on the other hand continuously emits new values on the interval, which means it works as expected with this overload and probably makes it better suited to this task regardless.Fixes #1628