Ensure output of Normalize is bounded between zero and one #1400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1399 .
The current version of
Normalize
implements ConvertScale withshift
in "raw", unscaled, units.https://github.com/bonsai-rx/bonsai/blob/404b092b501fbd9a0db5ccce76bf695623e6ba7c/Bonsai.Vision/Normalize.cs#LL34C17-L34C32
However, the native function from opencv seems to follow algebraic order of operations (i.e. Multiplication -> Addition), resulting in applying the scaling first and the shift second.
It seems the easiest way to correct this would be to normalize the shift by the range: