-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for replacing selected nodes #1009
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will introduce support for replacing selected nodes in the workflow, extending the current option for replacing group operators to subject declarations and individual workflow nodes.
The following replacements will be supported:
SubjectExpressionBuilder
>SubjectExpressionBuilder
: type of subject is changed, name is preservedSubjectExpressionBuilder
>Subject
: declaration changes toMulticastSubjectBuilder
, name is set to name ofSubject
SubjectExpressionBuilder (Source)
>Subject
: declaration changes toSubscribeSubjectBuilder
, name is set to name ofSubject
MulticastSubjectBuilder
>SubjectExpressionBuilder
: multicast sink changes to specified declaration type, name is preservedSubscribeSubjectBuilder
>SubjectExpressionBuilder (Source)
: subscribe changes to specified subject source declaration type, name is preservedWorkflowExpressionBuilder
>WorkflowExpressionBuilder
: type of nested workflow is changed, name, description, and inner contents are preservedSource
>SubjectExpressionBuilder (Source)
: source changes to specified subject declaration typeAny
>Any
: any single node is replaced with the specified toolbox operatorAny (multi-selection)
>Any
: multi-selection is converted first to an intermediate group and then replaced with the specified toolbox operatorGlossary:
SubjectExpressionBuilder
: Any subject declaration (PublishSubject
,ReplaySubject
, etc) created from an input sequence.SubjectExpressionBuilder (Source)
: Any subject declaration created as a source (e.g. context menu > Create Source).SubscribeSubjectBuilder
: A source created by subscribing to the specified subject.MulticastSubjectBuilder
: A sink emitting all values from the input sequence to the specified subject.WorkflowExpressionBuilder
: Any nested group operator, except include workflows.Subject
: Any named subject listed in the toolbox under theSubject
category.Source
: A selection of nodes with no predecessors in the workflow.Any
: Any other operator not mentioned above.Fixes #600
Fixes #1010