Ensure nested mashup sources are always serialized

bonsai-rx · Sep 27, 2022 · 888782c · 888782c
1 parent c70ca30
commit 888782c
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/Bonsai.Editor/Layout/LayoutHelper.cs b/Bonsai.Editor/Layout/LayoutHelper.cs
@@ -273,16 +273,13 @@ static void SerializeMashupVisualizerSettings(
             foreach (var source in mashupVisualizer.MashupSources)
             {
                 var sourceIndex = GetMashupSourceIndex(source, topologicalOrder);
-                if (sourceIndex.HasValue)
-                {
-                    var mashupSource = SerializeMashupSource(sourceIndex.Value, source.Visualizer, topologicalOrder);
-                    root.Add(mashupSource);
-                }
+                var mashupSource = SerializeMashupSource(sourceIndex, source.Visualizer, topologicalOrder);
+                root.Add(mashupSource);
             }
         }
 
         static XElement SerializeMashupSource(
-            int sourceIndex,
+            int? sourceIndex,
             DialogTypeVisualizer visualizer,
             IEnumerable<Node<ExpressionBuilder, ExpressionBuilderArgument>> topologicalOrder)
         {
@@ -301,7 +298,7 @@ static XElement SerializeMashupSource(
 
             visualizerSettings = new XDocument(
                 new XElement(MashupSettingsElement,
-                new XElement(MashupSourceElement, sourceIndex),
+                sourceIndex.HasValue ? new XElement(MashupSourceElement, sourceIndex.Value) : null,
                 new XElement(nameof(VisualizerDialogSettings.VisualizerTypeName), visualizerType.FullName),
                 new XElement(nameof(VisualizerDialogSettings.VisualizerSettings), visualizerSettings.Root)));
             return visualizerSettings.Root;