Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bdm): Do not set a default productVersion #45

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

rbioteau
Copy link
Member

@rbioteau rbioteau commented Oct 4, 2023

The productVersion attribute is not relevant.

This attribute will now be used at runtime when generating the java jar to identify the productVersion used for generation

The `productVersion` attribute is not relevant.

This attribute will now be used at runtime when generating the java jar
to identify the productVersion used for generation
@github-actions github-actions bot added the bug Something isn't working label Oct 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Contributor

@akantcheff akantcheff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akantcheff akantcheff merged commit 3dd7d3c into develop Oct 9, 2023
8 checks passed
@akantcheff akantcheff deleted the fix/remove_product_version branch October 9, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants