Capabilities handler accepts also boolean capabilities (#409)

bonigarcia · Oct 26, 2023 · bf88832 · bf88832
1 parent 2771cb0
commit bf88832
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 7 deletions.
diff --git a/src/main/java/io/github/bonigarcia/seljup/CapabilitiesHandler.java b/src/main/java/io/github/bonigarcia/seljup/CapabilitiesHandler.java
@@ -112,7 +112,7 @@ private Optional<Class<? extends Capabilities>> getOptionsClass() {
                 && browserType.get() == BrowserType.FIREFOX)) {
             return Optional.of(FirefoxOptions.class);
         } else if (isOpera || (browserType.isPresent()
-                        && browserType.get() == BrowserType.OPERA)) {
+                && browserType.get() == BrowserType.OPERA)) {
             return Optional.of(ChromeOptions.class);
         } else if (type == EdgeDriver.class || (browserType.isPresent()
                 && browserType.get() == BrowserType.EDGE)) {
@@ -178,13 +178,21 @@ private void handleCapabilities(Class<? extends Capabilities> optionsClass,
                     && browser.get().getCapabilities() != null) {
                 Method setCapabilityMethod = optionsClass
                         .getMethod("setCapability", String.class, String.class);
-
+                Method setCapabilityBooleanMethod = optionsClass.getMethod(
+                        "setCapability", String.class, boolean.class);
                 @SuppressWarnings("unchecked")
-                Set<Entry<String, String>> caps = ((LinkedTreeMap<String, String>) browser
+                Set<Entry<String, Object>> caps = ((LinkedTreeMap<String, Object>) browser
                         .get().getCapabilities()).entrySet();
-                for (Entry<String, String> entry : caps) {
-                    setCapabilityMethod.invoke(options, entry.getKey(),
-                            entry.getValue());
+
+                for (Entry<String, Object> entry : caps) {
+                    Object value = entry.getValue();
+                    if (value.getClass().equals(Boolean.class)) {
+                        setCapabilityBooleanMethod.invoke(options,
+                                entry.getKey(), entry.getValue());
+                    } else {
+                        setCapabilityMethod.invoke(options, entry.getKey(),
+                                entry.getValue());
+                    }
                 }
             }
         } catch (Exception e) {

diff --git a/src/test/resources/browsers-caps.json b/src/test/resources/browsers-caps.json
@@ -9,7 +9,8 @@
              ],
              "capabilities" : {
                 "custom:cap-1": "custom-value-1",
-                "custom:cap-2": "custom-value-2"
+                "custom:cap-2": "custom-value-2",
+                "custom:cap-3": true
              }
          }
       ],