Skip to content

Commit

Permalink
updated Bromite ad-block filter list, and wildcard domain blacklists
Browse files Browse the repository at this point in the history
  • Loading branch information
bongochong committed Nov 14, 2022
1 parent 7587016 commit 1f2aa97
Show file tree
Hide file tree
Showing 3 changed files with 9,735 additions and 12,829 deletions.
Loading

12 comments on commit 1f2aa97

@ignoramous
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi: Does CPBL have a wildcard equivalent for Light and Full? If so, I'd switch Rethink (link) to use those (as they are smaller and hence consume lesser memory).

@bongochong
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly!

Full
Light

I do prefer using my complete lists - as there's virtually no potential for error or tricky whitelisting situations with them - but the wildcard lists should be production-ready, and I have been maintaining them as an option for a while. If you notice any issues using them with Rethink (the app or resolvers) do let me know.

@ignoramous
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointers.

as there's virtually no potential for error or tricky whitelisting situations with them

I have asked @badmojr about this, and they feel there's not much to worry with using wildcard lists. I feel it is safe to move to it because of their recommendation. It is surprising to hear that you have reservations, but I'm curious if you know of instances where wildcards were more trouble than their worth?

@bongochong
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust your judgement, so proceed as you see fit. Any reticence is instinctual, and only related to a few unexpected exclusion patterns I had to write in the past. At this point it should all be sorted out and good to go!

@ignoramous
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we'll see how it goes when these wildcards auto-ship in a day! (:

serverless-dns/blocklists@ed8ecba

@badmojr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointers.

as there's virtually no potential for error or tricky whitelisting situations with them

I have asked @badmojr about this, and they feel there's not much to worry with using wildcard lists. I feel it is safe to move to it because of their recommendation. It is surprising to hear that you have reservations, but I'm curious if you know of instances where wildcards were more trouble than their worth?

I think the general rule of thumb is use the wildcard format of a list if the maintainer supports it.

It's how AdGuard DNS 2.0 approaches wildcards.
e.g:
Wildcard blocking: https://github.com/AdguardTeam/HostlistsRegistry/blob/main/filters/general/filter_24_1Hosts_Lite/configuration.json
https://github.com/AdguardTeam/HostlistsRegistry/blob/main/filters/general/filter_3_PeterLoweFilter/configuration.json

Plain blocking: https://github.com/AdguardTeam/HostlistsRegistry/blob/main/filters/general/filter_4_DanPollocksList/configuration.json
https://github.com/AdguardTeam/HostlistsRegistry/blob/main/filters/general/filter_33_StevenBlack/configuration.json

@bongochong
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchas gracis @ignoramous and @badmojr!

@bongochong
Copy link
Owner Author

@bongochong bongochong commented on 1f2aa97 Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S. @ignoramous I use the Rethink resolver for my full list (1-eaaacaa.max.rethinkdns.com) on one device, and just remembered that I've been utilizing a tld-compressed version of my full hosts file every time I connect to my travel router (which runs OpenWrt w/the Ad-Block plugin). Haven't run into any issues for quite some time, and after inspecting some diffs, my wildcard domains lists contain identical content (sans "*.") to the tld-compressed versions of my hosts files generated by said device. Basically, the wildcard lists are 100% in order, and have been for a long while now. I also have some observations regarding the latest build of the Rethink app that I intend to share with you, but it will take me a bit to organize that into coherent sentences, and I'll shoot you an e-mail when that's all put together. Many thanks for staying on top of things, and consistently working on improvements to your app and DNS services.

@ignoramous
Copy link

@ignoramous ignoramous commented on 1f2aa97 Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically, the wildcard lists are 100% in order, and have been for a long while now. I also have some observations regarding the latest build of the Rethink app that I intend to share with you, but it will take me a bit to organize that into coherent sentences, and I'll shoot you an e-mail when that's all put together.

Looking forward to it!

Many thanks for staying on top of things, and consistently working on improvements to your app and DNS services.

Well, we are doing a lot less than we had hoped... but I am glad things are at an acceptable level (:

We further reduced operating costs (by 3x) over the past 3 months and so things are looking good on that front for at least another year! The next step (after integrating wireguard in the app) is to get the paid DNS services out of the door to not only have the service pay for itself but give some of it back to the creators of these lists that RDNS uses. Let's see.

@ignoramous
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jfyi: Lists by Lightswitch05 (Developer Dan) break with wildcard-matching: lightswitch05/hosts#301

@bongochong
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ignoramous. Good to know. Use whichever format you think is most effective. The latest release of the Rethink application fixed most of the issues I was going to eMail you about by the way. A very dear loved one passed a few days ago, so while I am mourning and recovering from that, updates to this repo will likely be occurring on a biweekly as opposed to weekly basis.

@ignoramous
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞 My deepest sympathy. Stay strong.

Please sign in to comment.