Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #43

Merged
merged 15 commits into from
Aug 23, 2023
Merged

Refactoring #43

merged 15 commits into from
Aug 23, 2023

Conversation

bolshakov
Copy link
Owner

@bolshakov bolshakov commented Aug 19, 2023 •
edited
Loading

The goal of this PR is to introduce missing abstractions and make stoplight admin more testable

Fixes #35

@bolshakov bolshakov marked this pull request as ready for review August 20, 2023 14:06
@bolshakov bolshakov changed the title Add LightsRepository Refactoring Aug 20, 2023
Lokideos
Lokideos approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@Lokideos Lokideos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Great work!
It is not compatible with the previous configuration, so I'd mention in the Upgrade.md that the initializer for the Stoplight Admin should be slightly modified.

lib/stoplight_admin/actions/green.rb Outdated Show resolved Hide resolved
lib/stoplight_admin/actions/green_all.rb Outdated Show resolved Hide resolved
@bolshakov bolshakov merged commit b4b8f59 into master Aug 23, 2023
3 checks passed
@bolshakov bolshakov deleted the feature/lights-repository branch August 23, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lokideos Lokideos Lokideos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Business logic refactoring
2 participants
@bolshakov @Lokideos