Make phone number optional during address validation. (#25)

Co-authored-by: MykolaMalovanets <[email protected]>
bold-commerce · Nov 16, 2023 · 4d3eb6d · 4d3eb6d
1 parent 04ab747
commit 4d3eb6d
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/Checkout/Api/Platform/Cart.php b/Checkout/Api/Platform/Cart.php
@@ -26,7 +26,9 @@ public static function getCart(
         }
         try {
             self::prepareStore($quote);
-            $quote->getShippingAddress()->setCollectShippingRates(true);
+            if (!$quote->getIsVirtual()) {
+                $quote->getShippingAddress()->setCollectShippingRates(true);
+            }
             $quote->collectTotals();
             $quoteData = Bold_Checkout_Service_Extractor_Quote::extract($quote);
         } catch (Mage_Core_Model_Store_Exception $e) {
@@ -300,6 +302,7 @@ private static function updateAddress(
         $address->setLastname($lastname);
         $address->setSameAsBilling($sameAsBilling);
         $address->setSaveInAddressBook($saveInAddressBook);
+        $address->setShouldIgnoreValidation(true);
     }
 
     /**
@@ -344,6 +347,10 @@ private static function prepareStore(Mage_Sales_Model_Quote $quote)
         /** @var Mage_Customer_Model_Session $customerSession */
         $customerSession = Mage::getSingleton('customer/session');
         $customerSession->setCustomerId($quote->getCustomerId());
+        $quote->getBillingAddress()->setShouldIgnoreValidation(true);
+        if (!$quote->isVirtual()) {
+            $quote->getShippingAddress()->setShouldIgnoreValidation(true);
+        }
     }
 
     /**

diff --git a/Checkout/Api/Platform/Customer/Address.php b/Checkout/Api/Platform/Customer/Address.php
@@ -19,6 +19,9 @@ public static function validate(
         $payload = json_decode($request->getRawBody());
         $addressData = isset($payload->address) ? $payload->address : new stdClass();
         $address = Bold_Checkout_Service_Customer_Address_Convertor::getAddress($addressData);
+        if (!$address->getTelephone()) {
+            $address->setTelephone('0000000000');// Set a default phone number placeholder if none is provided.
+        }
         $validationResult = $address->validate();
         if ($validationResult === true) {
             return Bold_Checkout_Rest::buildResponse($response, json_encode(

diff --git a/Checkout/Api/Platform/Customers.php b/Checkout/Api/Platform/Customers.php
@@ -103,7 +103,9 @@ private static function getCustomer(stdClass $customerData)
         $customer->setFirstname($firstname);
         $customer->setLastname($lastname);
         foreach ($addresses as $address) {
-            $customer->addAddress(Bold_Checkout_Service_Customer_Address_Convertor::getAddress($address));
+            $customerAddress = Bold_Checkout_Service_Customer_Address_Convertor::getAddress($address);
+            $customerAddress->setShouldIgnoreValidation(true);
+            $customer->addAddress($customerAddress);
         }
         return $customer;
     }