Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 6.0 support #202

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Add Rails 6.0 support #202

merged 1 commit into from
Apr 16, 2019

Conversation

eitoball
Copy link
Contributor

This PR should allow Rails 6.0 to be used with.

It is currently testing against 6.0.0.beta3 on Travis CI. Since Rails 6.0.0 is probably released during RailsConf 2019 which starts on April 30th, I think that beta3 won't be much different from official release of 6.0.0.

Copy link
Collaborator

@rmm5t rmm5t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for this. One quick change requested. I'm on mobile at the moment. If you don't get to it before I get back to a big keyboard sometime tomorrow, I can adjust it, but I can merge earlier if you get to it first.

source 'https://rubygems.org'

gemspec path: "../"
gem "railties", "6.0.0.beta3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to:

">= 6.0.0.beta3", "< 6.1"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed. Thank you for reviewing.

@rmm5t rmm5t merged commit ad9dbf9 into bokmann:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants