helpers should not modify passed options #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you want to store options into a variable to avoid duplication,
unfortunately, the fa_icon changes the passed options. Therefore, the
second time that fa_icon is called with the same variable, some of
values are removed, e.g. class.
```slim
- icon_options = { class: 'foo' }
= fa_icon 'user', icon_options
= fa_icon 'tags', icon_options # this one will not have the foo class
```
|
+1 |
|
Perfect, clean, concise PR. Thanks! |
|
Thank you for quick merge. |
|
v4.7.0.1 was just released with this change. Thanks again! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to store options into a variable to avoid duplication,
unfortunately, the fa_icon changes the passed options. Therefore, the
second time that fa_icon is called with the same variable, some of
values are removed, e.g. class.