potential bug in business_days.after

[andresod]

please consider following code:

require 'json'
require 'date'
require 'business_time'

mydate = Date.parse("April 23, 2014")
printf "10 days after %d-%d-%d\n ", mydate.year, mydate.month, mydate.day
printf "using 10.business_days.after(<date>)\n"
print 10.business_days.after(mydate)
print "\n\n"
mydate = Date.parse("April 21, 2014")
printf "10 days after %d-%d-%d\n ", mydate.year, mydate.month, mydate.day
printf "using 10.business_days.after(<date>)\n"
print 10.business_days.after(mydate)
print "\n"

result:

10 days after 2014-4-23
 using 10.business_days.after(<date>)
2014-05-06 17:00:00 -0700

10 days after 2014-4-21
 using 10.business_days.after(<date>)
2014-05-05 17:00:00 -0700

expected the computed days to be 2 days apart.

[andresod]

in businessdays_after, instead of:

time = Time.zone ? Time.zone.parse(time.strftime('%Y-%m-%d %H:%M:%S %z')) : Time.parse(time.strftime('%Y-%m-%d %H:%M:%S %z'))

this seems to work:

time = Time.zone ? Time.zone.parse(time.strftime('%Y-%m-%d %H:%M:%S %z')) : Time.parse(time.strftime('%Y-%m-%d %H:%M:%S'))

in other words, if time zone is not set, then don't try to parse it.

I'm just starting out with Ruby, so I might be wrong :)

[bokmann]

Its going to be a few days before I can fully appreciate this and release it, but it certainly seems like your line is the right thing to do. I'll hopefully incorporate and release soon.

thanks!

[pkananen]

Is this going to be merged soon?

[pkananen]

@bokmann any update?

[bokmann]

I just tested your code against the latest gem and it no longer fails. The expected 2 days apart seems to work.