Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyter_bokeh 4.0.0 #196

Merged
merged 8 commits into from
Feb 22, 2024
Merged

jupyter_bokeh 4.0.0 #196

merged 8 commits into from
Feb 22, 2024

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Jul 19, 2023

This is preparatory PR for jupyter_bokeh 3.0.8 release. The main change is support for jupyterlab 4 (Python side). Base on my testing, this soft of works, i.e. plots/layouts appear, however handles don't work and thus there's no interactivity.

@scimax
Copy link

scimax commented Aug 3, 2023

Hi @mattpap , I just came across your PR because I experienced the same issue as stated in #195 . However, since you mention that the handles don't work anymore in your case, I was a bit confused.
I had a running instance of jupyterlab 4 still open while i was installing jupyter_bokeh 3.0.7. During the installation, jupyterlab was downgraded, but not the current instance, since it was still running. Then I imported bokeh in the open notebook and it worked. Doesn't that mean that theoretically jupyter_bokeh 3.0.7. is compatible with jupyterlab 4.x? Interactivity was working.
Or do I misinterpret something here in my observations?

So the main question I wanted to ask: could it be that the lack of interactivity was something platform-specific?

@bryevdv
Copy link
Member

bryevdv commented Aug 3, 2023

@scimax "handles" refers specifically to the old push_notebook API, is that what you were using? "Bokeh app embedded in a notebook" is a different kind of usage that does not involve handles.

@philippjfr philippjfr changed the title jupyter_bokeh 3.0.8 jupyter_bokeh 4.0.0 Feb 13, 2024
jupyter_bokeh/_version.py Outdated Show resolved Hide resolved
@philippjfr
Copy link
Contributor

I've updated this PR to build against JupyterLab 4 now which included:

  • Updating the package.json with latest Jupyter packages
  • Replace setup.py and previous jupyter packaging approach with modern Jupyter tooling based on hatch(ling)
  • Some typing changes.

scripts/deploy.sh Outdated Show resolved Hide resolved
@philippjfr
Copy link
Contributor

@mattpap Would you mind testing and then releasing?

scripts/deploy.sh Outdated Show resolved Hide resolved
@bryevdv
Copy link
Member

bryevdv commented Feb 14, 2024

Please just update the README with a few lines how to build/deploy using the new system

@philippjfr
Copy link
Contributor

Nothing should have changed on that front, but @mattpap when you get a chance do document the deployment process.

@mattpap mattpap merged commit 9e94b21 into main Feb 22, 2024
2 checks passed
@mattpap mattpap deleted the mattpap/jupyter_bokeh_3.0.8 branch February 22, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants