Fix CheckPostalCode to Validate Input Strictly #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evnaz
force-pushed
the
fix-postal-code-validation
branch
from
ef7238a
to
8632fca
Compare
bojanz
reviewed
Oct 28, 2023
| @@ -83,13 +83,21 @@ func (f Format) CheckRegion(region string) bool { | |||
| // | |||
| // An empty postal code is considered valid. | |||
| func (f Format) CheckPostalCode(postalCode string) bool { | |||
| if postalCode == "" || f.PostalCodePattern == "" { | |||
There was a problem hiding this comment.
A PostalCodePattern tends to be empty only if a format does not have a postalCode field at all. In which case the current check might be enough? Or do we gain anything by compiling a "^.+$" regexp and matching the postalCode against it in that case?
There was a problem hiding this comment.
Thanks for the context! Not sure if it's good to report true when the format doesn't require a postal code and the input is a non empty string. Probably ^$ regex would make more sense in that case as then you can detect that there's something unexpected provided.
|
Great catch, thanks! I have a single question (posted above), then we can proceed with merging and releasing this. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with the postal code validation in the library, which currently returns true for inputs that contain valid postal codes but also include additional, invalid characters. For example, the current regex for France would validate "A12345" as a valid postal code, even though it contains an invalid character "A".
To fix this, I've introduced a new function on the
Formattype that returns a modified version for the postal code regex by adding start^and end$anchors, ensuring that the regex will only pass if the entire input string is a valid postal code, with no additional characters, and use this modified pattern in theCheckPostalCode. The underlyingPostalCodePatternremains intact as it might be useful for matching, e.g. extracting postal code from the full address string.