Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade protoreflect from 1.9.0 to 1.15.1 #416

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

pbabbicola
Copy link
Contributor

@pbabbicola pbabbicola commented May 9, 2023

An older version of protoreflect imported google.golang.org/grpc/test/grpc_testing directly, instead of generating it or directly using it from google.golang.org/grpc/interop/grpc_testing. google.golang.org/grpc has removed it in the latest version (v1.55.0).

Unfortunately this makes old versions of protoreflect and therefore ghz incompatible with google.golang.org/grpc v1.55.0. Upgrading protoreflect would solve the issue.

I ran the tests locally, but there's two that are failing (TestRunClientStreaming/with_stream_cancel and TestRunBidi/with_stream_cancel). They are also failing on master for me, so maybe it's not important, but I thought i should mention it.

(There's also a linting error when I run the linter, from preexisting code. I can fix it also if you would like me to.)

@bojand bojand merged commit 3b7b67a into bojand:master Jun 18, 2023
@pbabbicola pbabbicola deleted the upgrade-protoreflect branch June 21, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants