This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
#12 Does not work with secondary entrypoints without a package.json
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ensure generator is built before testing against libs
* to ensure entrypoints are found with efficiency we do not scan directories anymore by ourself
* if a doc can be matched to a secondary entrypoint we fall back to the primary one
* remove custom implementations of `ng-packagr` interfaces
bohoffi
deleted the
bugfix/12-bug-does-not-work-with-secondary-entrypoints-without-a-packagejson
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The previous version relied on the existence of a
package.jsonfile in every entrypoint direction - which isn't required anymore.Issue Number: #12
What is the new behavior?
We rely on
ng-packagrnow to properly identify all entrypoints.Does this PR introduce a breaking change?