Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding default net.Dialer #78

Merged
merged 7 commits into from
Nov 26, 2023
Merged

Allow overriding default net.Dialer #78

merged 7 commits into from
Nov 26, 2023

Conversation

fidraC
Copy link
Contributor

@fidraC fidraC commented Oct 1, 2023

Not sure if this is appropriate but I had a situation pop up where I needed to define my own net.Dialer so that I could override the default DNS resolver.

@bogdanfinn
Copy link
Owner

@fidraC thank you for your contribution! For me that looks good so far.
What do you think about using this option also in the newConnectDialer() not only in the directDialer ?
Does that make sense that someone maybe wants to override the underlying net.dialer there aswell?

@fidraC
Copy link
Contributor Author

fidraC commented Oct 3, 2023

What do you think about using this option also in the newConnectDialer() not only in the directDialer ?

This makes sense that if someone wants to override the default dialer, they would want to override all dialers for the particular client. I'll look through the code and see what needs to be changed.

@fidraC
Copy link
Contributor Author

fidraC commented Oct 3, 2023

done!

@bogdanfinn bogdanfinn merged commit 6ad3a0f into bogdanfinn:master Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants