fixed readAllBodyWithStreamToFile function #123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using
tls-client
in conjunction with Node.js and encountered an issue while handling large file downloads. Specifically, I tried to setstreamOutputPath
to save the response body directly to a file. However,tls-client
attempted to send the entire response as a JSON object, causing it to hang. Additionally, when using thewithDebug
option, it printed the entire response body, which was very inefficient.To address these issues, I made the following updates to the code:
streamOutputPath
: WhenstreamOutputPath
is set, the code now returns an empty response body instead of attempting to convert the entire response to JSON.These changes ensure that large file downloads are handled efficiently and that the response body is managed appropriately when using
streamOutputPath
.