-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: adds aarch64 wheels #121
Conversation
@bodono can you look at this? We are getting a lot of complaints about cvxpy not being able to install on linux because of the SCS dependency. This MR would fix the issue potentially. |
CIBW_ARCHS_MACOS: x86_64 universal2 | ||
CIBW_ARCHS_LINUX: auto aarch64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm no expert on this stuff, but it seems to be failing due to only wanting one of these to be set at a time. I think you will need to put the two architectures inside the matrix, so you can use something like {{ matrix.arch }} here, and then it will kick off 2x the jobs, one for each arch choice.
Sure, let's get this landed! I took a look at the problem and it seems relatively minor to fix, I left the following comment:
|
Hey @bodono , thanks for your reply. However, I am following the cibuildwheel setup from cvxpy, see here and it seems to allow setting both the linux and macos aarch envs. Also I noticed that all CI tests are passing except the source distribution. It has something to do with meson builds and not being able to find BLAS? Not sure if this has anything to do with the changes I've added. Could you take a look please? |
Oh is that the only one failing now? That's nothing to do with this change, I also ran into that error and fixed it here: #122 Probably easiest thing is for me to pull that change out as a separate PR, land it, then you rebase on top (assuming the test pypi upload still gives me trouble). |
ok sounds good :), let me know if I can be of any help for the pypi upload issue (seems to still be some, looking at your other PR) |
Ok that change has landed, go ahead and rebase on top and the tests should hopefully pass. |
Sorry to be a pain here, but I'm looking at what was built in the PR I submitted and I see aarch64 wheels: https://github.com/bodono/scs-python/actions/runs/12595266757/job/35104211556 I'm wondering if this change is necessary? I never got around to tagging a new release (which might have created new wheels), but can do it asap. |
You are right maybe it's not necessary, I am not sure. Can you try tagging a new release to see if it would work? |
It looks to me to have worked: https://pypi.org/project/scs/#files |
seems to have worked on my local (using py13 and linux)
Thanks @bodono ! |
Thanks for your help with this @Transurgeon , and also thanks to @enzbus who updated the action to allow aarch64 wheels. |
Yes @bodono this was already done in the PR from last year, but you hadn't made a new tag 🙏👍 |
reference issue: #111 .
suggestion for fix by @matteoettam09 .
following the PR in cvxpy#2054.