Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

feat(ensure): add ensure_states feature #296

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

ccutrer
Copy link
Collaborator

@ccutrer ccutrer commented Oct 18, 2021

closes #275

# Switch1.on
# Switch2.on
# end
def ensure_states
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have this same code in rules as well. In logging I was going to pull this out into a common element.
Thinking along the lines of

thread_local(key: value) do

end

Don't need to add it to the PR, but WDYT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, seems like a decent de-duplication

@boc-tothefuture
Copy link
Owner

LGTM.
It is missing docs - I am comfortable merging and then I can do a PR for docs. You OK with that?

@ccutrer
Copy link
Collaborator Author

ccutrer commented Oct 19, 2021

🤦 I thought I had docs for this one. Probably cause I spent a good amount of time writing very good tests. Yeah, we can merge and add docs later.

@boc-tothefuture
Copy link
Owner

Ok, I can't write docs tonight.. But I will prep a PR with docs early tomorrow then merge the two of them right after each other.

@boc-tothefuture boc-tothefuture merged commit 71ac48b into boc-tothefuture:main Oct 19, 2021
@jimtng jimtng linked an issue Oct 19, 2021 that may be closed by this pull request
@github-actions
Copy link

🎉 This PR is included in version 4.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ccutrer ccutrer deleted the ensure_states branch October 24, 2021 21:43
ccutrer pushed a commit to ccutrer/openhab-jrubyscripting that referenced this pull request Dec 27, 2021
feat(ensure): add ensure_states feature

Former-commit-id: 71ac48b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optimistic command pattern
2 participants