New 'completions' command, and various tab-completion fixes and improvements#649

Open

phil-s wants to merge 45 commits intobobthecow:mainfrom phil-s:phil-s/completions

+569-120

Commits on Aug 14, 2020

Document the word-break limitations of the Readline completion

Phil Sainty
authored and
phil-s
committed
Add 'completions' command

Phil Sainty
authored and
phil-s
committed
Add 'completions' to the needCompleteClass() list

Phil Sainty
authored and
phil-s
committed
Make AbstractMatcher::startsWith() treat $prefix as a verbatim string

Phil Sainty
authored and
phil-s
committed
Add tokenIsValidIdentifier() for generic tab-completion tests

Phil Sainty
authored and
phil-s
committed
Use tokenIsValidIdentifier() in getInput() instead of matching T_STRING

Phil Sainty
authored and
phil-s
committed
Renaming variables for consistency

Phil Sainty
authored and
phil-s
committed
Do not return completions if valid input was not obtained

Phil Sainty
authored and
phil-s
committed
Add missing documentation

Phil Sainty
authored and
phil-s
committed
Bug fix for ClassNamesMatcher::hasMatched()

Phil Sainty
authored and
phil-s
committed
Bug fix for KeywordsMatcher::hasMatched()

Phil Sainty
authored and
phil-s
committed
Bug fix for CommandsMatcher::hasMatched()

Phil Sainty
authored and
phil-s
committed
Use tokenIsValidIdentifier() instead of T_STRING matching in hasMatched() methods

Phil Sainty
authored and
phil-s
committed
Use tokenIsValidIdentifier() with T_OBJECT_OPERATOR matching in hasMatched() methods

Phil Sainty
authored and
phil-s
committed
Comments

Phil Sainty
authored and
phil-s
committed
Minor refactoring

Phil Sainty
authored and
phil-s
committed
If not completing a valid prefix, consider it an empty string

Phil Sainty
authored and
phil-s
committed
Don't trim trailing spaces and tabs from command input

Phil Sainty
authored and
phil-s
committed
Treat T_OPEN_TAG and ';' the same way for the purposes of completion

Phil Sainty
authored and
phil-s
committed
Support string tokens in AbstractMatcher::hasToken() and tokenIs()

Phil Sainty
authored and
phil-s
committed
Fix inconsistencies with completion of variables

Phil Sainty
authored and
phil-s
committed
Improve the 'previous token' blacklisting in hasMatched() methods

Phil Sainty
authored and
phil-s
committed

Commits on Aug 15, 2020

Bug fix for getNamespaceAndClass()

Phil Sainty
authored and
phil-s
committed
Allow an incomplete class name in getNamespaceAndClass()

Phil Sainty
authored and
phil-s
committed

Commits on Aug 16, 2020

fixup! Add 'completions' command
Phil Sainty
committed

Commits on Aug 17, 2020

fixup! Add tokenIsValidIdentifier() for generic tab-completion tests
Phil Sainty
committed
fixup! Use tokenIsValidIdentifier() in getInput() instead of matching T_STRING
Phil Sainty
committed
fixup! Use tokenIsValidIdentifier() instead of T_STRING matching in hasMatched() methods
Phil Sainty
committed
fixup! If not completing a valid prefix, consider it an empty string
Phil Sainty
committed
fixup! Support string tokens in AbstractMatcher::hasToken() and tokenIs()
Phil Sainty
committed
fixup! Fix inconsistencies with completion of variables
Phil Sainty
committed
fixup! Allow an incomplete class name in getNamespaceAndClass()
Phil Sainty
committed
fixup! Fix inconsistencies with completion of variables
Phil Sainty
committed
fixup! Add 'completions' command
Phil Sainty
committed
fixup! If not completing a valid prefix, consider it an empty string
Phil Sainty
committed
fixup! Use tokenIsValidIdentifier() in getInput() instead of matching T_STRING
Phil Sainty
committed
fixup! Add tokenIsValidIdentifier() for generic tab-completion tests
Phil Sainty
committed
fixup! Add tokenIsValidIdentifier() for generic tab-completion tests
Phil Sainty
committed
fixup! Fix inconsistencies with completion of variables
Phil Sainty
committed
fixup! Document the word-break limitations of the Readline completion
Phil Sainty
committed
fixup! Add 'completions' command
Phil Sainty
committed
fixup! Support string tokens in AbstractMatcher::hasToken() and tokenIs()
Phil Sainty
committed
fixup! Add tokenIsValidIdentifier() for generic tab-completion tests
Phil Sainty
committed
Update the list of commands in AbstractMatcher::needCompleteClass()
Phil Sainty
committed
fixup! Update the list of commands in AbstractMatcher::needCompleteClass()
Phil Sainty
committed