Old-style Closure dump format?

[bobthecow]

The new Closure formatting feels less intuitive and easily grokkable than before. Should we re-implement the function-signature-style formatting in terms of VarDumper? I took a look, but didn't get very far. @nicolas-grekas how tough would this be?

[bobthecow]

/cc @GrahamCampbell

[nicolas-grekas]

you could do this by adding a virtual prop, let's name it "signature", when you generate the signature of the closure in PHP style?

[bobthecow]

It would be awesome to show less when dumping a Closure, not more :)

Compare:

My preference would be to show the old style for most output, and the new style (maybe with the signature as well?) for dump --all and possibly regular dump.

[nicolas-grekas]

Just acking this. So, you would also represent "use" right at their place in the signature I believe. When default arg values are array, would you present them on the same line, inlined?

[nicolas-grekas]

What about this:

=> Closure {#177
    signature: "function ($a) use ($b)",
    use: [
      "$b" => 5,
    ],
    file: "/home/nicolas.grekas/Code/psysh/src/Psy/ExecutionLoop/Loop.php(76) : eval()'d code",
    line: "1 to 2",
}

And in short mode (the default one), we hide everything but the signature?

=> Closure {#177
    signature: "function ($a) use ($b)"
}

I'd like to keep the Closure {#177 info, it's important to still tell the user that an anonymous functions is an object of type Closure imo.

[bobthecow]

@nicolas-grekas I'm all about removing redundant or obvious information where possible. We probably don't need to tell users that an anonymous function is an object of type Closure because all anonymous functions are objects of type Closure ;)

Is there a straightforward way to render it just like before (or maybe with #177 in between the parens)? If not, that's cool, but I feel like that's the most information dense way to represent anonymous functions and it'd be awesome if we could do it again.

[nicolas-grekas]

Fixed by symfony/symfony#27768