Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle type parameters properly in the type matcher #2

Open
bobg opened this issue Aug 19, 2022 · 3 comments
Open

Handle type parameters properly in the type matcher #2

bobg opened this issue Aug 19, 2022 · 3 comments

Comments

@bobg
Copy link
Owner

bobg commented Aug 19, 2022

The type matcher still has some gaps in its implementation. One of those is that type parameters are not handled, but should be.
@bobg bobg mentioned this issue Aug 24, 2022
Open
5 tasks
@bobg
Copy link
Owner Author

bobg commented Aug 25, 2022

One way to address this issue is to reimplement checkImplementsTarget entirely in terms of types.Implements (which would mean constructing a *ast.Interface to represent Target).

@bobg
Copy link
Owner Author

bobg commented Aug 31, 2022

Type parameters are not available to reflect types. So this task is blocked on #2 (comment)

@bobg
Copy link
Owner Author

bobg commented Apr 29, 2023

(However, there is a proposal to add type params to reflect: golang/go#54393.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bobg