Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP fix for #160 - Configurable Line Height. This currently makes the… #433

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bobbylight
Copy link
Owner

@bobbylight bobbylight commented Feb 20, 2022

… line height configurable when word wrap is NOT enabled. Line number list is also updated.

Fold indicators do not currently work properly - they only update in the demo app because I've tied '8' and '9' keypresses to tweaking the line height for quick testing.

I think what still needs to be done is:

  • fold indicator immediate updating
  • fold indicator rendering of 'active' fold line
  • "classic" style of fold indicators doesn't render the "region" line indicator completely
  • and everything when word wrap is enabled

@bobbylight bobbylight linked an issue Feb 20, 2022 that may be closed by this pull request
@bobbylight bobbylight self-assigned this Feb 20, 2022
@bobbylight bobbylight force-pushed the fix-160-configurable-line-height branch 2 times, most recently from aff062a to 9191bf4 Compare November 23, 2024 20:47
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 52.17391% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.38%. Comparing base (b0f9bed) to head (04b4524).

Files with missing lines Patch % Lines
...main/java/org/fife/ui/rtextarea/RTextAreaBase.java 25.00% 9 Missing ⚠️
...main/java/org/fife/ui/rtextarea/FoldIndicator.java 50.00% 1 Missing ⚠️
...ea/src/main/java/org/fife/ui/rtextarea/Gutter.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #433      +/-   ##
============================================
- Coverage     80.40%   80.38%   -0.03%     
- Complexity     7793     7794       +1     
============================================
  Files           178      178              
  Lines         30250    30264      +14     
  Branches       3911     3913       +2     
============================================
+ Hits          24323    24328       +5     
- Misses         4256     4264       +8     
- Partials       1671     1672       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bobbylight bobbylight force-pushed the fix-160-configurable-line-height branch from 9191bf4 to fa2e6f7 Compare November 30, 2024 14:02
… line height configurable when word wrap is NOT enabled. Line number list is also updated. Fold indicators do not currently work properly - they only update in the demo app because I've tied '8' and '9' keypresses to tweaking the line height for quick testing. I think what still needs to be done is: fold indicator immediate updating, fold indicator rendering of 'active' fold line, and *everything* when word wrap is enabled
@bobbylight bobbylight force-pushed the fix-160-configurable-line-height branch from fa2e6f7 to 04b4524 Compare December 8, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configurable line height
1 participant