Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug at line 246 in org.fife.rsta.ac.js.SourceCompletionProvider - "this." is not implicit in JavaScript #2

Open
pvlasov opened this issue Oct 21, 2013 · 3 comments
Labels

Comments

@pvlasov
Copy link

pvlasov commented Oct 21, 2013

I believe that line 246 in org.fife.rsta.ac.js.SourceCompletionProvider:
parseTextAndResolve(set, "this." + text);

shall be commented out because in JavaScript object properties shall be always resolved through this. which is different from Java behavior.

@stevenupton
Copy link
Collaborator

Hi pvlasov,

I believe I had to add this because otherwise this. was not recognised when parsing text. Perhaps I need to revisit it.

Steve

@pvlasov
Copy link
Author

pvlasov commented Oct 21, 2013

Steve,

I commented this line in my set-up and observed correct behavior in
which /this./ was not assumed and as such instance fields and methods
stopped from appearing in a list of completions after Ctrl-Space where
only locals, parameters, and globals belong. After the fix field and

methods appear only in the list after /this/.

Best regards, Pavel.

On 10/21/2013 5:20 AM, Steve Upton wrote:

Hi pvlasov,

I believe I had to add this because otherwise this. was not recognised
when parsing text. Perhaps I need to revisit it.

Steve


Reply to this email directly or view it on GitHub
#2 (comment).

@stevenupton
Copy link
Collaborator

OK, That is fine. I may need to move that code into a Rhino specific plugin. I needed it for some Server side scripting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants