Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header Problem Fixed #162

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Erayushsingh
Copy link

@Erayushsingh Erayushsingh commented Oct 5, 2024

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🚩 Other

Description

Related Tickets & Documents

Added to documentation?

  • 📜 readme
  • 🙅 no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

Copy link

what-the-diff bot commented Oct 5, 2024

PR Summary

  • Improved Layout Accuracy
    The header's positioning has been changed from 'relative' to 'fixed'. This means the header will now stay at the top of the page even when users scroll down.

  • Enhanced Styling and Readability
    Class names in the header and navigation have been modified, ensuring a proper background for the header and improved contrast for the text. This promotes better readability of the website content.

  • Cleaner HTML Code
    Unnecessary space in the class attributes has been removed, making the HTML code cleaner and more streamlined.

  • Adjusted Navigation Menu
    The navigation menu retains its styles but its positioning and visibility have been adjusted for a better user experience.

  • Clearer HTML Formatting
    Additional whitespace has been added to the HTML structure for clearer formatting, making it easier to read and understand the code.

@Erayushsingh
Copy link
Author

Hello @bobbyiliev ,
Please accept pull request with HactoberFest HactoberFest-accepted tag.

Copy link
Owner

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you but this feels a bit odd, some of the HTML elements are on top of each other.

image

@Erayushsingh
Copy link
Author

Okay @bobbyiliev ,I will make the necessary changes.
I just want to ask that to improve UI can i change the colors or any thing that is necessary.

@Erayushsingh
Copy link
Author

Header problem has been fixed again .Please review it and accept my PR with tag hactoberfest hactoberfest-accepted.

Copy link
Owner

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like that now the svg is also stick to the navbar and covers all elements down the page:

image

Let's leave the menu as it is and not stick it. Feel free to pick up other issues to contribute to if you wish 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants